chore(deps): accept RUSTSEC-2026-0285 until the rustls fix clears cooldown - #562
Merged
Merged
Conversation
…ldown The advisory lands on rustls 0.23.37, reached only as an outbound HTTPS client via reqwest. The fix (rustls 0.23.45) published 2026-09-14 and is still inside our 168h dependency cooldown, so unblock the deny gate now and drop the entry with the bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 94.06% 94.06% -0.01%
==========================================
Files 93 93
Lines 26459 26459
==========================================
- Hits 24889 24888 -1
- Misses 1570 1571 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
denyCI gate started failing on every branch after RUSTSEC-2026-0285 was published againstrustls0.23.37 (GHSA-2mjx-qc3c-rqvc, same bug class as Go's CVE-2025-61730). It is not introduced by any pending change —rustlsarrives transitively throughreqwest → hyper-rustls / tokio-rustls.[advisories].ignorelist indeny.tomlwith the usual rationale + exit condition comment, so the supply-chain gate stops blocking unrelated PRs (currently chore(deps): bump taiki-e/install-action from 2.87.4 to 2.87.11 in the github-actions group across 1 directory #560 and chore(deps): bump the cargo group with 3 updates #561).Why this is safe to accept temporarily
rustlsis only used as an outbound HTTPS client (feed fetches, image proxy). The advisory is that a peer can send handshake messages in plaintext that should have been encrypted, withoutrustlsrejecting the connection; the handshake transcript stays authenticated, so a network-position attacker cannot alter or complete a handshake with it.Exit condition
The fix is
rustls >= 0.23.45, published 2026-09-14T15:11Z. Under this project's 168-hour dependency cooldown it becomes adoptable on 2026-09-21. Follow-up tracked in #563 — the ignore entry gets dropped in the same change as the bump.Test plan
cargo deny checklocally →advisories ok, bans ok, licenses ok, sources okdenyjob green on this PR🤖 Generated with Claude Code