Skip to content

chore(image-upload):configure cloudinary - #1

Open
hephzaron wants to merge 8 commits into
masterfrom
cloudinary-api
Open

chore(image-upload):configure cloudinary#1
hephzaron wants to merge 8 commits into
masterfrom
cloudinary-api

Conversation

@hephzaron

Copy link
Copy Markdown
Owner

Modify content handling by using cloudinary API

Comment thread client/webpack.config.js Outdated
devtool: setDevTool()
},
node: {
fs: "empty"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

Comment thread client/webpack.config.js Outdated
},
plugins: [
new HtmlWebpackPlugin({
template: __dirname + "/client/public/index.html",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use path.join() or path.resolve() instead of + to create paths no-path-concat
Strings must use singlequote quotes

Comment thread client/webpack.config.js Outdated
__dirname + "/client/src/index.jsx",
],
output: {
path: __dirname + "/client/dist",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use path.join() or path.resolve() instead of + to create paths no-path-concat
Strings must use singlequote quotes

Comment thread client/webpack.config.js Outdated
test: /\.html$/,
use: ['html-loader']
entry: [
__dirname + "/client/src/index.jsx",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use path.join() or path.resolve() instead of + to create paths no-path-concat
Strings must use singlequote quotes

Comment thread client/webpack.config.js Outdated
if (isDevelopment) {
publicPath = `http://localhost:${PORT}/`
} else if (isProduction) {
publicPath = `${ROOT_URL}`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

Comment thread client/webpack.config.js Outdated
publicPath = `${ROOT_URL}`
}
return publicPath;
let publicPath

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

Comment thread client/webpack.config.js Outdated
} else if (isProduction) {
return 'source-map'
} else {
return 'inline-source-map'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

Comment thread client/webpack.config.js Outdated
return 'eval'
} else if (isProduction) {
return 'source-map'
} else {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary 'else' after 'return' no-else-return

Comment thread client/webpack.config.js Outdated
if (isDevelopment) {
return 'eval'
} else if (isProduction) {
return 'source-map'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

Comment thread client/webpack.config.js Outdated
return 'inline-source-map'
}
if (isDevelopment) {
return 'eval'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

@coveralls

coveralls commented Apr 24, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 83.712% when pulling 137e30e on cloudinary-api into 655763a on master.

done();
});
}).timeout(5000);
it('it should not post user credentials to database where email exist on the database', (done) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 111 exceeds the maximum line length of 100 max-len

});
}).timeout(5000);
// Each username should be unique
it('it should not post user credentials to database where username exist on the database', (done) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 87 exceeds the maximum line length of 100 max-len

}
});
},
down: function(queryInterface, Sequelize) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Sequelize' is defined but never used no-unused-vars

password,
confirmPassword
} = req.body;
if (username === (null || '') || email === (null || '') || password === (null || '') || confirmPassword === (null || '')) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 28 exceeds the maximum line length of 100 max-len

return res.status(401).send({ message: 'Your session has expired. Please try logging in again' });
let decoded = jwt.decode(token, secret, { algorithm: 'HS256' });
if (decoded === null) {
return res.status(401).send({ message: 'Your session has expired. Please try logging in again' });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 88 exceeds the maximum line length of 100 max-len

if (isDevelopment) {
publicPath = `http://localhost:${PORT}/`
} else if (isProduction) {
publicPath = `${ROOT_URL}`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

const setPublicPath = () => {
let publicPath
if (isDevelopment) {
publicPath = `http://localhost:${PORT}/`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

}
}
const setPublicPath = () => {
let publicPath

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

} else {
return 'inline-source-map'
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

} else if (isProduction) {
return 'source-map'
} else {
return 'inline-source-map'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

return 'eval'
} else if (isProduction) {
return 'source-map'
} else {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary 'else' after 'return' no-else-return

if (isDevelopment) {
return 'eval'
} else if (isProduction) {
return 'source-map'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi


const setDevTool = () => {
if (isDevelopment) {
return 'eval'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

CLOUDINARY_API_KEY,
CLOUDINARY_API_SECRET,
CLOUD_NAME,
} = process.env

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants