Pin egglog-experimental commit + --locked (alternative to #1628) - #1629
Closed
oflatt-claude wants to merge 1 commit into
Closed
Pin egglog-experimental commit + --locked (alternative to #1628)#1629oflatt-claude wants to merge 1 commit into
oflatt-claude wants to merge 1 commit into
Conversation
Alternative to floating on `--branch main`: pin an exact egglog-experimental commit and pass --locked so `cargo install` honors its committed Cargo.lock instead of re-resolving to the newest compatible versions. This makes the egglog install fully reproducible and immune to both egglog-experimental main moving and transitive dependency drift (e.g. the clap_derive 4.6 -> syn 3.x change that broke the build). Bump the pinned rev deliberately to pick up egglog updates. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
We should merge this after egglog experimental gets updated with the upstream fix. Closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1628 — pick one.
Same root cause as #1628 (see there for the full write-up:
cargo installignores the lockfile and re-resolves, andclap_derive4.6 →syn 3.xdropped thesyn/fullfeature egglog was relying on).This variant goes further than #1628 for full reproducibility:
--locked→ honor egglog-experimental's committedCargo.lockinstead of re-resolving (fixes the break).--rev <sha>→ stop floating on--branch main, so the egglog version only changes when we deliberately bump the pin.Trade-off vs #1628: reproducible and immune to both upstream main moving and dependency drift, but requires a manual rev bump to pick up egglog updates. #1628 (just
--locked, keep--branch main) still auto-follows main.Note: pinning the rev without
--lockedwould not fix the bug —cargo installwould still re-resolve transitive deps.--lockedis the load-bearing part; the rev pin is for reproducibility.🤖 Generated with Claude Code