Lock cargo when cloning egglog-experimental - #1631
Merged
Merged
Conversation
`cargo install` ignores the checked-in Cargo.lock unless `--locked` is
passed, so every CI run re-resolved egglog-experimental's dependency tree
to the newest compatible versions. That recently broke the build: egglog's
`add_primitive` proc macro parses full Rust expressions and needs syn's
"full" feature, but only got it via feature-unification from clap_derive
(pulled in through egglog's `bin` feature). When clap_derive 4.6 moved to
syn 3.x, its "full" feature stopped applying to egglog's syn 2.x, and the
proc macro failed to compile ("enable syn's features=[\"full\"]").
Two changes for a reproducible install:
- `--locked` makes cargo honor egglog-experimental's committed, tested
lockfile instead of re-resolving to latest.
- pin an exact `--rev` instead of floating `--branch main`, so the egglog
version only changes when we deliberately bump the pin. (Bump this rev
to pick up egglog updates.)
`--locked` is the part that fixes the break; the rev pin is good practice
for reproducibility.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a variant of #1628 as discussed in that PR.