Improved partition creation handling #1841
Open
goshev wants to merge 1 commit into
Open
Conversation
…vely create partitions earlier. A failure to create partitions will not result in an operation failure during early attempts. Signed-off-by: Dimitar Goshev <dimitar.goshev@here.com>
roegi
reviewed
May 27, 2026
| const bestEffortPreCreation = partitionOffset >= Math.floor(PARTITION_SIZE / 2) && version % preCreationInterval === 0; | ||
| const parameters = [this.schema, this.table, Math.floor(version / PARTITION_SIZE) + 1, PARTITION_SIZE]; | ||
|
|
||
| if (nearFull) { |
Contributor
There was a problem hiding this comment.
The following code duplication could be solved by adding the differentiating condition simply into the catch clause. This would also make the code more readable again when it comes to parameter re-substitution.
roegi
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle missing partition creation during versioned writes and proactively create partitions earlier.
A failure to create partitions will not result in an operation failure during early attempts.