Skip to content

MMSUP-2904: Fix issue with loading outputs of GENERIC OutputSets #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roegi merged 1 commit into from
Jul 17, 2026
Merged

MMSUP-2904: Fix issue with loading outputs of GENERIC OutputSets #1891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/Step.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,9 @@ private void replaceOutputSet(String outputSetName, OutputSet outputSet) {
* @return The outputs that have been registered for the specified outputSet (so far).
*/
protected List<Output> loadStepOutputs(OutputSet outputSet) {
return loadOutputs(defaultBucket(), Set.of(toS3Path(outputSet)), outputSet.modelBased);
//TODO: Refactor S3Client to be bucket-agnostic
S3Uri s3Uri = outputSet.toS3Uri(getJobId());
return loadOutputs(s3Uri.bucket(), Set.of(s3Uri.key()), outputSet.modelBased);
}

private List<Output> loadOutputs(String bucketName, Set<String> s3Prefixes, boolean modelBased) {
Expand Down Expand Up @@ -355,6 +357,7 @@ private List<Input> loadInputs(InputSet inputSet) {
* @return All outputs for the specified InputSet
*/
private List<Output> loadOutputsFor(InputSet inputSet) {
//TODO: Refactor S3Client to be bucket-agnostic
S3Uri s3Uri = inputSet.toS3Uri(jobId);
return loadOutputs(s3Uri.bucket(), Set.of(s3Uri.key()), inputSet.modelBased());
}
Expand Down
Loading