executor: root action execution at /execroot - #38
Open
zbarsky-openai wants to merge 1 commit into
Open
zbarsky-openai wants to merge 1 commit into
zbarsky-openai wants to merge 1 commit into
Conversation
Rust action output validation fails under actiond because its short `/workspace`
execution root also occurs inside unrelated source and generated documentation:
```text
Error: ProcessWrapperError("compiled Rust output bazel-out/darwin_arm64-fastbuild/bin/external/rules_rs++crate+cargo__backoff-0.4.0/libbackoff-2164882781.rlib embeds the absolute working directory /workspace. Do not retain env!(\"CARGO_MANIFEST_DIR\") or env!(\"OUT_DIR\") in compiled code; include_str!() and include_bytes!() may use those values only for compile-time file access")
```
Use `/execroot` as the action-visible execution root throughout action staging,
working-directory resolution, mounted input-tree lookup, absolute output
symlinks, and dependency-file prefix stripping. Update the existing execution,
symlink, depfile, and end-to-end fixtures as well as the architecture document.
Using the conventional execution-root name removes the false positive without
patching or weakening rules_rust's existing absolute-path detector. The
monorepo workaround in openai/openai#1345884 can then be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust action output validation fails under actiond because its short
/workspaceexecution root also occurs inside unrelated source and generated documentation:
Use
/execrootas the action-visible execution root throughout action staging,working-directory resolution, mounted input-tree lookup, absolute output
symlinks, and dependency-file prefix stripping. Update the existing execution,
symlink, depfile, and end-to-end fixtures as well as the architecture document.
Using the conventional execution-root name removes the false positive without
patching or weakening rules_rust's existing absolute-path detector. The
monorepo workaround in openai/openai#1345884 can then be removed.