vm: expose child processes through procfs - #47
Open
zbarsky-openai wants to merge 1 commit into
Open
zbarsky-openai wants to merge 1 commit into
zbarsky-openai wants to merge 1 commit into
Conversation
Subprocess supervisors fail inside actiond guests because the compact kernel omits the procfs child-process list: ```text RuntimeError: cannot inspect adopted subprocesses through /proc/thread-self/children SupervisedProcessCleanupError: subprocess supervisor did not confirm descendant cleanup ``` Linux exposes `/proc/<pid>/task/<tid>/children` only when `CONFIG_PROC_CHILDREN` is enabled. The option defaults to disabled with `allnoconfig`, even when procfs itself is available. Enable `CONFIG_PROC_CHILDREN` in both ARM64 and x86_64 guest kernels. The rebuilt ARM64 kernel exposes actual child PIDs, all three previously failing subprocess-supervisor cases pass inside the guest, and the full downstream suite completes with 898 passing tests and one existing skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subprocess supervisors fail inside actiond guests because the compact
kernel omits the procfs child-process list:
Linux exposes
/proc/<pid>/task/<tid>/childrenonly whenCONFIG_PROC_CHILDRENis enabled. The option defaults to disabled withallnoconfig, even when procfs itself is available.Enable
CONFIG_PROC_CHILDRENin both ARM64 and x86_64 guest kernels.The rebuilt ARM64 kernel exposes actual child PIDs, all three previously
failing subprocess-supervisor cases pass inside the guest, and the full
downstream suite completes with 898 passing tests and one existing skip.