Conversation
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a repository-wide
@cuda//:library_modebuild setting so consumers can switch CUDA linkage without changing dependency labels. The flag acceptsshared,static, orsystemand defaults to the existing shared behavior.For each complete
foo/foo_static/foo_systemfamily, the generated proxy now keeps the explicit suffixed targets stable and makes the unsuffixedfootarget select the requested variant. Targets that do not expose a complete family are unchanged. cuDART also gains the semanticcudart_staticalias needed to participate consistently.The proxy already selects concrete repositories by CUDA version. The generator now composes that dimension with linkage mode through private per-mode version aliases, then exposes a single public mode-selecting alias. This preserves existing labels and defaults while avoiding nested configurable attributes.
Validation
bazel --nohome_rc build //...Generated with Codex.