Skip to content

Bound command health check pipe waits - #94

Open
Spikhalskiy wants to merge 1 commit into
hermeticbuild:masterfrom
Spikhalskiy:dmitry/bound-command-health-checks
Open

Spikhalskiy wants to merge 1 commit into
hermeticbuild:masterfrom
Spikhalskiy:dmitry/bound-command-health-checks

Conversation

@Spikhalskiy

@Spikhalskiy Spikhalskiy commented Sep 7, 2026

Copy link
Copy Markdown

Fixes #92.

  • Bound the post-exit wait for command health-check output pipes.
  • Preserve a successful health-check exit when only inherited pipes time out.
  • Add a helper-process regression test.

Copilot AI lite review requested due to automatic review settings September 7, 2026 20:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T21:01:22.752901Z 3337b3a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Spikhalskiy
Spikhalskiy force-pushed the dmitry/bound-command-health-checks branch from 3337b3a to e6fc612 Compare September 7, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command health checks can hang on inherited output pipes

2 participants