Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4540fe7f4f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
rafikk
force-pushed
the
rafikk/nkkqylysynoq
branch
3 times, most recently
from
September 16, 2026 15:55
ccd5d84 to
17f0214
Compare
rafikk
commented
Sep 16, 2026
rafikk
force-pushed
the
rafikk/nkkqylysynoq
branch
from
September 17, 2026 08:12
17f0214 to
a677414
Compare
rafikk
force-pushed
the
rafikk/nkkqylysynoq
branch
from
September 17, 2026 10:00
a677414 to
014240d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
itest_local_environment, a rule for declaring abazel runnable target for local development. It is very similar toitest_service_groupbut carries an additional attribute for explicitly mapping port labels to stable port numbers.Unlike
itest_service_group, it is intended to be a terminal rule. It does not return_ServiceGroupInfo, meaning it cannot be used as a dependency inservice_testor composed with other service groups or local environments. The purpose of the target is strictly interactive local development viabazel run.The primary motivation for this PR is to avoid the use of Bazel flags for port mapping. While the Bazel flags are very flexible, they have a few downsides:
itest_local_environmentavoids these problems. It encodes the port reservations in Starlark, and port numbers only need to be unique within a specific environment target. As these are intended for end-users, port collisions across disjoint environments/groups do not cause a problem in practice.The
port_assignmentscontinue to be overridable via Bazel flags.