Conversation
finn-ball
marked this pull request as ready for review
August 12, 2026 09:33
Member
|
Thanks for the PR, my reasoning on this is #193 (comment). Apologies for not having time to actually do what I intend yet, this one has been a bit low on my priority list given the easy workaround :) Curious to hear if this would solve it for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust_test_suitemacro through a publicrules_rswrapperbzl_librarytargetWhy
rules_rsrecommends loading Rust rules through its facade, but users currently need to loadrust_test_suitedirectly from@rules_rust. This adds API parity with the pinned upstream ruleset and makes migration and consistent loading simpler.Validation
buildifier rs/rust_test_suite.bzl rs/BUILD.bazel test/BUILD.bazelbazel test //:rust_test_suitefrom thetestworkspace (2 tests passed)git diff --cached --check