Conversation
Do not pass rustc arguments through compute_select, which factors dependency sets by deduplicating, sorting, and hoisting common items. Keep repeated option names next to their values, and keep flags from a single platform conditional on that platform. Render the select directly in repository_utils without changing rust_crate attributes. Both generated-call regression tests fail before the fix and pass afterward on Bazel 9. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve argument order and duplicates in
rustc_flagsandrustc_flags_select. The dependency renderer converted these lists to sets, so repeated-Cor--cfgarguments lost their option names. It also made a flag unconditional when only one platform was listed. Render these flag selections directly, retaining an empty default branch.Added two regression tests covering repeated arguments, platform isolation, and legacy platform labels. Both fail before the fix and pass afterward on Bazel 9.
Assisted by OpenAI Codex.