Conversation
Prefer root-module configurations for each toolchain repository. Otherwise select compiler, edition, rustfmt, and rust-analyzer maxima before declaring repositories or downloading archives. Preserve errors for conflicting compiler flags and incomparable release channels. Keep original root tags for extension dependency metadata and preserve tagless default-toolchain imports. Fixes #256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple modules declare the same toolchain repository, use the root module's complete configuration if present. Otherwise, independently select the highest Rust version, edition, rustfmt version, and rust-analyzer version. Resolve configurations before downloading archives so overridden dependency versions are ignored. Keep actionable errors for conflicting compiler flags and mixed stable/beta/nightly channels, and preserve normal and dev dependency metadata for tagless default-toolchain imports.
Validation: all 11
//rs/toolchains:toolchain_config_teststests pass; five actual Bazel module configurations verify dependency maxima, root overrides, normal/dev imports, and no-tag defaults. Buildifier formatting andgit diff --checkpass.Fixes #256
-zbarskybot