fix: scope Rust compiler toolchains to declared target triples - #260
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
declare_rustc_toolchainsin a workspace package currently breaks wildcardcquerywhen the target platform is outsidetarget_triples. Add one configurable alias matching the declared triples to every generatedtoolchain().target_settings, preserving the existing BPF, bootstrap, and channel restrictions. With unsupported platforms excluded from toolchain resolution,target_triplecan default to the first declared triple andrust_stdcan default toempty_stdlib. The empty standard library avoids analyzing source-built standard libraries for unsupported platforms. Reject emptytarget_triplesand document registration precedence.Validation: all eight Bazel 9 analysis tests pass, covering both declared musl triples, GNU fallback, bootstrap and BPF selection, and unsupported-platform analysis of every generated target, including a source-only declaration. Wildcard
cquery //rs/toolchains/tests/...passes on an excluded GNU platform with its execution platform registered. Confirmed the original code reproduces the reportedselecterror; buildifier formatting/lint andgit diff --checkpass.Fixes #246.
-zbarskybot