Conversation
Sort flag variants and classify their argument forms once in _prefix_pwd_to_flag, rather than repeating both operations for every C/C++ toolchain argument. Preserve the existing ordered matching and path rewrites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo build-script analysis normalizes linker, C, and C++ flags through
_prefix_pwd_to_flag. The helper currently sorts the same flag spellingsand checks their argument form for every toolchain argument. Compute both
once per call while preserving the existing ordered matches and path
rewrites.
In full-graph
bazel build --nobuild //...profiles, cumulative sampledStarlark CPU under
_cargo_build_script_implfell from 114 seconds to27–30 seconds in two patched runs. Overall elapsed time varied with major
GC, so the profiles do not establish a consistent wall-time improvement.