Remove unused grep-includes dependency from prost - #62
Merged
Merged
Conversation
The prost aspect no longer has any consumer of _grep_includes. The shared Rust compilation code removed grep_includes usage in 0a1e587. Validation: buildifier and git diff --check pass. Prost tests encounter a dependency-provider analysis error also reproduced with the unchanged prost code. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
_grep_includesattribute fromrust_prost_aspect. The shared Rust compilation code stopped consuminggrep_includesin commit 0a1e587.Validation: Buildifier and
git diff --checkpass. The attempted prost tests encountered a dependency-provider analysis error that was also reproduced with the unchanged prost code; runtime validation remains incomplete.Assisted-by: OpenAI Codex