Skip to content

fix(zig_toolchain): avoid depending on coreutils touch in version validation - #674

Merged
aherrmann merged 1 commit into
hermeticbuild:mainfrom
nicdumz:fix-zig-toolchain-touch-dependency
Sep 4, 2026
Merged

aherrmann merged 1 commit into
hermeticbuild:mainfrom
nicdumz:fix-zig-toolchain-touch-dependency

Conversation

@nicdumz

@nicdumz nicdumz commented Aug 29, 2026

Copy link
Copy Markdown
Contributor
  • The version-validation action's shell script ran unqualified and with no declared env/PATH, so it inherits an empty action environment. On systems without an FHS-style /bin:/usr/bin (e.g. NixOS), bash's compiled-in fallback PATH doesn't resolve touch, and the action fails with touch: command not found even though bash itself was found via an explicit toolchain path.
  • Replace touch with printf, a bash builtin.

@nicdumz
nicdumz marked this pull request as ready for review August 29, 2026 13:39
…idation

The version-validation action's shell script ran unqualified and with no
declared env/PATH, so it inherits an empty action environment. On systems
without an FHS-style /bin:/usr/bin (e.g. NixOS), bash's compiled-in
fallback PATH doesn't resolve 'touch', and the action fails with
'touch: command not found' even though bash itself was found via an
explicit toolchain path.

Replace touch with printf, a bash builtin.
@aherrmann
aherrmann force-pushed the fix-zig-toolchain-touch-dependency branch from 9d1534d to 9fb6afd Compare September 4, 2026 07:54

@aherrmann aherrmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@aherrmann
aherrmann enabled auto-merge September 4, 2026 07:55
@aherrmann
aherrmann merged commit b6e0d3a into hermeticbuild:main Sep 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants