Skip to content

🐛 fix: Match submodules in modules pattern consistent with allow/deny#19

Merged
heumsi merged 1 commit intomainfrom
fix/modules-submodule-matching
Mar 30, 2026
Merged

🐛 fix: Match submodules in modules pattern consistent with allow/deny#19
heumsi merged 1 commit intomainfrom
fix/modules-submodule-matching

Conversation

@heumsi
Copy link
Copy Markdown
Owner

@heumsi heumsi commented Mar 30, 2026

Summary

  • modules pattern now automatically matches submodules, consistent with allow/deny behavior
  • e.g. modules: contexts.*.domain now matches contexts.boards.domain.models (previously required explicit .** suffix)
  • Captures (e.g. {context}) are preserved correctly for submodule matches

Closes #18

Test plan

  • Existing 75 tests pass (no regression)
  • Added 3 new tests for submodule matching in find_matching_rules:
    • Wildcard pattern with submodules
    • Named captures with submodules
    • Exact pattern with submodules

🤖 Generated with Claude Code

@heumsi heumsi force-pushed the fix/modules-submodule-matching branch from 82d2e3a to 8a004b8 Compare March 30, 2026 14:47
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@heumsi heumsi force-pushed the fix/modules-submodule-matching branch from 8a004b8 to 7266baa Compare March 30, 2026 14:48
@heumsi heumsi merged commit c11a79c into main Mar 30, 2026
5 checks passed
@heumsi heumsi deleted the fix/modules-submodule-matching branch March 30, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent submodule matching between modules and allow/deny

1 participant