Skip to content

✨ feat: Add rule name validation#21

Merged
heumsi merged 1 commit intomainfrom
feat/rule-name-validation
Mar 31, 2026
Merged

✨ feat: Add rule name validation#21
heumsi merged 1 commit intomainfrom
feat/rule-name-validation

Conversation

@heumsi
Copy link
Copy Markdown
Owner

@heumsi heumsi commented Mar 31, 2026

Summary

  • Config 로딩 시 rule name을 [a-zA-Z0-9_-]+ 패턴으로 검증
  • 유효하지 않은 rule name에 대해 ValueError 발생 (어떤 이름이 잘못됐는지 메시지에 포함)
  • 향후 # pdl: ignore[rule-name] 인라인 무시 문법을 위한 사전 작업

Test plan

  • 유효한 rule name 통과 확인 (attribute-matches-type, bool_method, rule1)
  • 공백 포함 rule name 에러 확인 (my rule)
  • 특수문자 포함 rule name 에러 확인 (rule!name)
  • 혼합 rule name 에러 확인 (rule name 123)
  • 기존 테스트 17개 전체 통과 확인

🤖 Generated with Claude Code

Validate rule names against [a-zA-Z0-9_-]+ pattern during config loading.
This ensures rule names are compatible with the upcoming inline ignore
comment syntax (# pdl: ignore[rule-name]).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@heumsi heumsi merged commit 377a9f7 into main Mar 31, 2026
5 checks passed
@heumsi heumsi deleted the feat/rule-name-validation branch March 31, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant