Conversation
…nderscore characters Rule names must now match [a-zA-Z0-9_-]+. This restriction ensures consistent naming and enables future inline ignore comments (# pnl: ignore=rule-name) to be parsed unambiguously. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
heumsi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorwhen a rule name contains characters outside[a-zA-Z0-9_-](e.g. spaces, special characters) during config loading.# pnl: ignore=rule-name).Changes
config.py: Add_validate_rule_name()function, called from_parse_rules()test_config.py: Add parametrized tests for valid/invalid rule namesTest plan
attribute-matches-type,bool_method,rule1,My-Rule_2)my rule,rule!name,rule name 123,rule.name,rule@name)🤖 Generated with Claude Code