Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.(dot) character in rule names, enabling module-path-style naming likeshared.domainorcontext.adapters.inbound[a-zA-Z0-9_-]+to[a-zA-Z0-9_.-]+Motivation
Inspired by heumsi/python-dependency-linter#27. Dots create a visual correspondence between rule names and their target module paths:
Changes
config.py: Updated_VALID_RULE_NAME_REand error message to allow dotsignore.py: Updated_IGNORE_REto allow dots in rule names within ignore commentstest_config.py: Movedrule.namefrom invalid to valid cases, addedshared.domaintesttest_ignore.py: Added tests for ignore comments with dotted rule namesTest plan
rule.name,shared.domain) accepted🤖 Generated with Claude Code