fix: Correct SVG class attributes and regenerate favicons #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where favicons were not displaying correctly. The root cause was identified as the use of `className` (a React-specific attribute) instead of `class` within the `public/favicon.svg` file. Changes: - Modified `public/favicon.svg` to replace all `className=` attributes with `class=`. - Re-generated all PNG favicons (`favicon-16x16.png`, `favicon-32x32.png`, `apple-touch-icon.png`) from the corrected `public/favicon.svg` to ensure they reflect the valid SVG structure. - Re-created `public/favicon.ico` using the updated PNGs. The links in `client/index.html` were already correct and did not require changes. This change should allow browsers to correctly render the SVG favicon and, by extension, ensure the derived PNGs/ICO are accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where favicons were not displaying correctly. The root cause was identified as the use of
className(a React-specific attribute) instead ofclasswithin thepublic/favicon.svgfile.Changes:
public/favicon.svgto replace allclassName=attributes withclass=.favicon-16x16.png,favicon-32x32.png,apple-touch-icon.png) from the correctedpublic/favicon.svgto ensure they reflect the valid SVG structure.public/favicon.icousing the updated PNGs.The links in
client/index.htmlwere already correct and did not require changes. This change should allow browsers to correctly render the SVG favicon and, by extension, ensure the derived PNGs/ICO are accurate.