feat: introduce tracing::instrument and more debug#79
Merged
Conversation
alemidev
added
core
zaaarf
force-pushed
the
feat/better-tracing
branch
from
2126cfe to
a4c2583
Compare
zaaarf
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
potentially problematic RPCs (mostly those connecting to new resources) now have proper
tracing::instrumentspans for better debugging. All background workers (workspace, cursor, buffer) now have their loops properly instrumented too, so that we know from which buffer controller an error came