feat(xion) + ADR-0004: ControllerBase に unauthorizedRedirect() hook を追加する (#278)#287
Merged
Merged
Conversation
ControllerBase::sessionCheck() は final で、unauth HTML page から redirect される先が framework-wide const LOGOUT_URI 固定だった。 アプリが複数の認証セクション (例: /admin/login と /auth/login) を 持つ場合、controller ごとに redirect 先を変える手段が無かった (FT5 finding F-3)。 ADR-0004 の選択肢 (b) hook 追加方式を採用: - sessionCheck() は final のまま、redirect 先決定だけを protected function unauthorizedRedirect(): string に抽出 - default 実装は LOGOUT_URI を返すので既存挙動不変 - subclass は hook の override 1 つで login URL を変えられる REST 経路は不変 (JSON SESSION-CLOSED のまま)。 ADR-0004 で「sessionCheck の dispatch invariant を保ちつつ、 redirect 先のみ open する」決定を記録。 Closes #278. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code