docs(review): NENE2 流の self-review checklists を docs/review/ に追加する (#271)#291
Merged
Conversation
) 姉妹 project NENE2 の docs/review/ pattern を NeNe に取り込む。 push 前に PR scope に合った checklist を歩いて、policy doc 参照 + 忘れがちな項目 (env override 形式、CSRF hook、schema parity、 generic envelope、FT report rules 等) を機械的にチェックできるよう にする。 NENE2 8 ファイルから、NeNe-specific な surface に再構成した 6 checklist + 1 README + 1 FT report 専用 checklist の計 8 file: - README.md — when-to-use map + policy 参照集 - rest-controller.md — REST handler (auto CSRF gate / ApiResponse / generic envelope / per-user mapper / TransactionManager 等) - html-controller.md — actionAction + Smarty (form POST / CSRF helper / unauthorizedRedirect hook / asset auto-discovery / Smarty escape 等) - database.md — schema parity (MySQL + SQLite) + mapper + TransactionManager + soft-delete / unique 制約のトレードオフ - openapi-contract.md — ADR-0003 generic envelope + per-endpoint examples + 自動契約テスト - docs-and-adr.md — policy doc / ADR / roadmap / follow-ups.md の同期と source-of-truth 維持 - release-ci.md — workflow / branch protection / auto-merge / CI 故障時の log 先行確認 (feedback-ci-debugging-discipline) - field-trial-report.md — FT methodology compliance (ADR-0002 + template + friction taxonomy) NENE2 にあって NeNe に該当する surface が無い 2 件 (frontend.md, middleware-security.md) は意図的に省略。NeNe は React frontend starter を持たず、bearer / API key / rate limit middleware も 未実装のため、checklist だけ先行させると aspirational になる。 docs/workflow.md と docs/CONTRIBUTING.md の Basic Flow に 「push 前に docs/review/ の checklist を歩く」step を挿入。 Closes #271. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist set
NENE2 にあって NeNe に surface が無い 2 件 (frontend.md, middleware-security.md) は意図的に省略。React frontend starter / bearer / rate limit / API key middleware が未実装で、checklist だけ作ると aspirational になるため。
Test plan
🤖 Generated with Claude Code