docs: McpHttpResponse の body 型誤記を修正 (#107)#114
Closed
hideyukiMORI wants to merge 2 commits into
Closed
Conversation
__all__ に含まれているがドキュメント化されていなかった公開 API を EN/JA 両版に追加: nene2.http: - PaginationQuery — PaginationQueryParser.parse() の戻り値型 - HealthCheckProtocol / HealthStatus — ヘルスチェック契約と結果型 nene2.database: - DatabaseHealthCheck — HealthCheckProtocol 実装、DB接続確認 - DatabaseConnectionException — DB接続不能時の例外 nene2.mcp: - McpHttpResponse — HttpxMcpClient の戻り値型(status_code / body / is_successful()) - McpHttpClientProtocol — カスタム MCP HTTP クライアントの構造的契約 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- body: dict | list → body: str(生のレスポンステキスト)に修正 - headers: dict[str, str] フィールドを追記 - request_id() -> str | None メソッドを追記 - McpHttpClientProtocol に has_authentication() を追記 - EN / JA 両ドキュメントに適用 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpHttpResponseのドキュメント記述を実装に合わせて修正body: dict | list(誤) →body: str生のレスポンステキスト (正)headers: dict[str, str]フィールドとrequest_id()メソッドを追記McpHttpClientProtocolにhas_authentication()を追記Closes #107
Test plan
docs/reference/framework-modules.mdの McpHttpResponse セクションが実コード(src/nene2/mcp/http_client.py)と一致していることを目視確認🤖 Generated with Claude Code