fix: PaginationQueryParser が非整数パラメータで ValidationException を raise する (#108)#115
Merged
Merged
Conversation
…raise する (#108) ?limit=abc / ?offset=xyz のような非整数クエリパラメータで int() 変換が ValueError を raise していたため、ErrorHandlerMiddleware に 500 として処理されていた。 ValueError を ValidationException (field / code: "invalid") に変換して、 正しく 422 Unprocessable Entity が返るようにした。 テスト3件追加: 非整数 limit / offset / 両方同時のエラー収集を確認 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?limit=abcや?offset=xyzのような非整数クエリパラメータでint()変換がValueErrorを raise し、ErrorHandlerMiddlewareに 500 として処理されていたバグを修正ValueErrorをValidationException（code="invalid"）に変換し、ErrorHandlerMiddleware経由で 422 が返るよう修正Closes #108
Test plan
uv run pytest tests/nene2/http/test_pagination.py -vが全パスすることuv run mypy src/とuv run ruff check src/が通ること🤖 Generated with Claude Code