fix: ThrottleMiddleware X-Forwarded-For リスク明記 + HTTP テスト fixture 整理 (#111 #113)#119
Closed
hideyukiMORI wants to merge 2 commits into
Closed
fix: ThrottleMiddleware X-Forwarded-For リスク明記 + HTTP テスト fixture 整理 (#111 #113)#119hideyukiMORI wants to merge 2 commits into
hideyukiMORI wants to merge 2 commits into
Conversation
…113) [#111] ThrottleMiddleware の X-Forwarded-For 偽装リスクをドキュメント化 - ADR-0006 に Known Limitations セクションを追加 - docs/reference/framework-modules.md (EN / JA) の ThrottleMiddleware 説明に注意書きを追加 [#113] HTTP テストの _client() を conftest fixture に移動 - tests/example/conftest.py を新規作成 — function スコープ client fixture - test_list_notes.py, test_tags.py, test_comment_http.py を pytest fixture スタイルに移行 - AppSettings(throttle_enabled=False) に統一してフレイクテスト防止 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#111 — ThrottleMiddleware X-Forwarded-For 偽装リスクをドキュメント化
docs/adr/0006-rate-limiting.mdに Known Limitations セクションを追加（X-Forwarded-For 偽装リスクと本番での reverse proxy 必須の旨を明記）docs/reference/framework-modules.md(EN / JA) の ThrottleMiddleware 説明に注意書きを追加#113 — HTTP テストの
_client()を conftest fixture に移動tests/example/conftest.pyを新規作成（function スコープのclientfixture）test_list_notes.py,test_tags.py,test_comment_http.pyを pytest fixture スタイルに移行AppSettings(throttle_enabled=False)に統一してレートリミットによるフレイクテストを防止Closes #111
Closes #113
Test plan
uv run pytestが全パスすること🤖 Generated with Claude Code