fix(#121): ApiKeyAuthMiddleware で TokenVerificationException を 401 に変換する#134
Merged
Merged
Conversation
BearerTokenMiddleware と同様に try/except を追加し、verifier.verify() が 例外を投げた場合も 401 を返すよう修正する。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiKeyAuthMiddlewareがTokenVerificationExceptionをキャッチしておらず、BearerTokenMiddlewareと非対称だったtry/except TokenVerificationExceptionを追加し、例外時も 401 を返すよう修正ExplodingVerifierを使ったテストで 500 → 401 の修正を検証Test plan
test_verifier_raises_token_verification_exception_returns_401— verifier が例外を投げても 401（新規）Closes #121
🤖 Generated with Claude Code