fix(#122): X-Request-Id を UUID v4 形式のみ許可してログインジェクションを防ぐ#135
Merged
Conversation
クライアント送信の X-Request-Id ヘッダーを UUID v4 正規表現でバリデーションし、 形式不正な場合は新規 UUID を生成することで改行文字等によるログ注入を防ぐ。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestIdMiddlewareがクライアント送信のX-Request-Idをバリデーションなしで structlog に設定していた^[0-9a-f]{8}-...-4...-[89ab]...-...$) でバリデーション、不正な値は新規 UUID に置換Test plan
test_invalid_request_id_is_replaced_with_new_uuid— 非UUID値は置換される（新規）test_newline_in_request_id_is_rejected— 改行インジェクションが防がれる（新規）Closes #122
🤖 Generated with Claude Code