fix: Note entity に slots=True を追加（#140）#141
Merged
Merged
Conversation
Tag/Comment entity は slots=True を持つが Note entity だけ欠落していた。 CLAUDE.md のルール「dataclass(frozen=True, slots=True)」に準拠させる。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/example/note/entity.pyのNotedataclass にslots=Trueを追加Tag/Commententity との一貫性を回復、CLAUDE.md の規約準拠変更内容
Background
2026-05-20 の包括的評価レポートで指摘。13 件の既存 PR (Issue #107〜#132) は
use_case.py の Input DTO を対象とした Issue #110 で対応済みだが、
note/entity.py本体は抜け落ちていた。Test plan
uv run pytest— 167 tests passed, 91.77% coverageuv run mypy src/— no issuesuv run ruff check src/ tests/— no issuesuv run ruff format --check src/ tests/— no issuesCloses #140
🤖 Generated with Claude Code