feat: local build support for block-node, mirror-node, relay, and explorer#4671
Open
JeffreyDallas wants to merge 15 commits into
Open
feat: local build support for block-node, mirror-node, relay, and explorer#4671JeffreyDallas wants to merge 15 commits into
JeffreyDallas wants to merge 15 commits into
Conversation
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
Contributor
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Contributor
E2E Test Report 10 files 94 suites 1h 24m 32s ⏱️ Results for commit 47cbcdb. |
Contributor
jeromy-cannon
added
the
PR: Merge Conflicts
…local-build # Conflicts: # src/core/helpers.ts
JeffreyDallas
removed
the
PR: Merge Conflicts
JeffreyDallas
added
the
PR: Needs Team Approval
jeromy-cannon
added
PR: Merge Conflicts
…local-build Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/commands/block-node.ts
JeffreyDallas
removed
the
PR: Merge Conflicts
jeromy-cannon
added
the
PR: Checks Failed
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
JeffreyDallas
added
Blocked
Contributor
Author
|
Wait #4798 to fix migration test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
--component-imageflag support to block-node, explorer commands (mirror-node and relay already had it); unifies--image-tagand--component-imageso both flags support local Docker images and registry images through the same code path.kind load docker-imageinto the Kind cluster and setsimagePullPolicy: Neveron the relevant Helm values — no manualkindorkubectlcommands required.image.tagoverride; no error is thrown.deployment state imagessubcommand — lists every pod in the deployment namespace with its running container image in an aligned table (COMPONENT / POD / CONTAINER / IMAGE), useful to verify a locally-built image was loaded correctly.BaseCommand(splitImageNameTag,isLocalImageAvailableInDocker,kindLoadComponentImage) and movesKindBuilderinjection to the base class; removes redundant constructor injection from block-node, relay, mirror-node, explorer, backup-restore, and init.--image-tagas deprecated in its flag description, pointing users to--component-image.checkDockerImageExiststo not log a spurious error whengrepexits 1 (no matches = image not found), which was printing noise on every non-local deploy.should not include the current block node in generated block node sourcesby filtering the current block node out of its own upstream sources list inprepareValuesArgForBlockNode.output of
deployment state imagesRelated Issues
Pull request (PR) checklist
package.jsonchanges have been explained to and approved by a repository managerTesting
The following manual testing was done:
block node add --image-tag 0.36.0-SNAPSHOTwith image absent from Docker → kind-load skipped, helm chart pulls from registry, no error loggedblock node add --image-tag 0.36.0-SNAPSHOTwith image present in Docker → kind-load executes,pullPolicy: Neverapplieddeployment state images --deployment solo-deployment→ aligned table printed with component names derived from pod labels / pod name stripping, no helm/kind dependency checkThe following was not tested: