Skip to content

feat: enhances solo deployment commands to prompt from local config instead of erroring when a required argument is missing. #4727

Open
jan-milenkov wants to merge 8 commits into
mainfrom
03291-03292-prompt-from-local-config
Open

feat: enhances solo deployment commands to prompt from local config instead of erroring when a required argument is missing. #4727
jan-milenkov wants to merge 8 commits into
mainfrom
03291-03292-prompt-from-local-config

Conversation

@jan-milenkov

Copy link
Copy Markdown
Contributor

Description

For deployment diagnostics connections, when --deployment is omitted it now shows a selectable list of deployments from local config (auto-selecting when only one exists) rather than prompting for free-text entry. Since this lives in the shared deployment resolver, every command that asks for a deployment benefits.

For deployment config list, when --cluster-ref is omitted it now offers a list of cluster references from local config plus an "All deployments" option, keeping the existing list-all behavior while letting users filter interactively.

Related Issues

Signed-off-by: Zhan Milenkov <instamenta@abv.bg>
@jan-milenkov jan-milenkov requested a review from a team as a code owner June 18, 2026 08:38
@trunk-io

trunk-io Bot commented Jun 18, 2026

Copy link
Copy Markdown

❌ This pull request failed tests. It has been removed from the merge queue. PR #4799 was used for testing. See more details here.

Failed Required Status Conclusion
Test Example (External Database Test) Failure
  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@jan-milenkov jan-milenkov self-assigned this Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Unit Test Results - Linux

38 tests  ±0   38 ✅ ±0   0s ⏱️ ±0s
17 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit edf0b5b. ± Comparison against base commit ee99636.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Unit Test Results - Windows

    1 files  ±0    337 suites  ±0   10s ⏱️ ±0s
1 068 tests ±0  1 068 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 072 runs  ±0  1 072 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit edf0b5b. ± Comparison against base commit ee99636.

♻️ This comment has been updated with latest results.

Ivo-Yankov
Ivo-Yankov previously approved these changes Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Report

 10 files   94 suites   1h 23m 48s ⏱️
301 tests 301 ✅ 0 💤 0 ❌
320 runs  320 ✅ 0 💤 0 ❌

Results for commit 87066d4.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

E2E Test Report

 10 files  ±0   94 suites  ±0   1h 26m 19s ⏱️ - 1m 25s
302 tests ±0  302 ✅ ±0  0 💤 ±0  0 ❌ ±0 
321 runs  ±0  321 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit edf0b5b. ± Comparison against base commit ee99636.

♻️ This comment has been updated with latest results.

@jan-milenkov jan-milenkov added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jun 19, 2026
@jeromy-cannon jeromy-cannon added the P2-⏭️💎 Next Milestone & Goals label Jun 19, 2026
@jeromy-cannon jeromy-cannon marked this pull request as draft June 19, 2026 15:51
@jeromy-cannon jeromy-cannon added PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. and removed PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jun 19, 2026
…om-local-config

# Conflicts:
#	src/core/resolvers.ts
Signed-off-by: Zhan Milenkov <instamenta@abv.bg>
@jan-milenkov jan-milenkov marked this pull request as ready for review June 22, 2026 09:30
@jan-milenkov jan-milenkov added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. and removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. labels Jun 22, 2026
@jeromy-cannon jeromy-cannon added PR: Merging... and removed PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2-⏭️💎 Next Milestone & Goals PR: Merging...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance deployment config list command Enhance deployment diagnostics connections command

3 participants