fix: pinger pod crash on one-shot startup#4749
Open
Ivo-Yankov wants to merge 9 commits into
Open
Conversation
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
|
✨ Submitted to Merge by @Ivo-Yankov. It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here. |
Ivo-Yankov
changed the title
Ivo-Yankov
changed the title
Contributor
Contributor
Contributor
E2E Test Report 10 files 94 suites 1h 23m 27s ⏱️ Results for commit b7acf39. |
Contributor
Ivo-Yankov
added
the
PR: Needs Team Approval
| } | ||
|
|
||
| await this.preInstall(); | ||
|
|
Contributor
There was a problem hiding this comment.
what are the reason or logic move up this preInstall step ?
Contributor
Author
There was a problem hiding this comment.
The preInstall method in the craneDependencyManager sends an API request to GitHub, which is redundant if isInstalledLocallyAndMeetsRequirements() === true.
JeffreyDallas
previously approved these changes
Jun 19, 2026
jeromy-cannon
added
P2-⏭️💎
jeromy-cannon
previously approved these changes
Jun 19, 2026
jan-milenkov
previously approved these changes
Jun 22, 2026
jan-milenkov
added
PR: Ready to Merge
jeromy-cannon
added
the
PR: Merge Conflicts
# Conflicts: # src/commands/one-shot/orchestrator/deploy/default-one-shot-deploy-orchestrator.ts
Ivo-Yankov
dismissed stale reviews from jan-milenkov and jeromy-cannon
via
13678f6
Ivo-Yankov
added
PR: Needs Team Approval
jeromy-cannon
added
PR: Merge Conflicts
# Conflicts: # src/commands/one-shot/orchestrator/deploy/default-one-shot-deploy-orchestrator.ts
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Ivo-Yankov
added
PR: Needs Team Approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes three small issues:
The Pinger pod crashes when
one-shotis deployed in parallel mode. This PR fixes it by enabling the Pinger only after the network nodes have started.The PR also fixes an issue with
CraneDependencyManager- on every one-shot command, even when the dependency exists locally, it makes an unnecessary request to the GitHub API, which may result in a 403 error due to GitHub's rate limiting.Removed a wait condition of the Relay during
one-shot. Sincev0.77.0, it no longer requires the network node to be running before it gets deployed.Related Issues
mirror-1-pinger-…in CrashLoopBackOff on "successful" deploys #4354Pull request (PR) checklist
package.jsonchanges have been explained to and approved by a repository managerTesting
The following manual testing was done:
The following was not tested:
Commit message guidelines
We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages: