Skip to content

chore: need to detect docker/podman resources available and let the user know#4758

Open
jan-milenkov wants to merge 3 commits into
mainfrom
2874-docker-podman-resource-preflight
Open

chore: need to detect docker/podman resources available and let the user know#4758
jan-milenkov wants to merge 3 commits into
mainfrom
2874-docker-podman-resource-preflight

Conversation

@jan-milenkov

@jan-milenkov jan-milenkov commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Add a step to solo one-shot * deploy that checks the resources allocated to docker/podman and displays a warning message if they are insufficient

The message's values are set in constants.ts with:

  • MINIMUM_RECOMMENDED_MEMORY_BYTES
  • MINIMUM_RECOMMENDED_CPU_CORES

Example (mock values):

⚠ Container engine resources look low for a Solo deployment:
  detected:    1GB memory, 2 CPU(s)
  recommended: >=3GB memory, >=4 CPU(s)
  The deployment may fail or run slowly. Increase the memory/CPU allocated to
  Docker/Podman (or free up resources) before continuing.

Related Issues

Signed-off-by: Zhan Milenkov <instamenta@abv.bg>
Signed-off-by: Zhan Milenkov <instamenta@abv.bg>
@jan-milenkov jan-milenkov self-assigned this Jun 22, 2026
@jan-milenkov jan-milenkov requested a review from a team as a code owner June 22, 2026 14:23
@trunk-io

trunk-io Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@jan-milenkov jan-milenkov added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jun 22, 2026
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Unit Test Results - Linux

38 tests  ±0   38 ✅ ±0   0s ⏱️ ±0s
17 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 862cad2. ± Comparison against base commit e8a8c90.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Unit Test Results - Windows

    1 files  ±0    337 suites  ±0   10s ⏱️ -1s
1 067 tests ±0  1 067 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 071 runs  ±0  1 071 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 862cad2. ± Comparison against base commit e8a8c90.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

E2E Test Report

 10 files  ±0   94 suites  ±0   1h 26m 13s ⏱️ + 2m 9s
302 tests ±0  302 ✅ ±0  0 💤 ±0  0 ❌ ±0 
321 runs  ±0  321 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 862cad2. ± Comparison against base commit e8a8c90.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon added the P3-⏭️⏭️💎 Future Milestone & Goals label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3-⏭️⏭️💎 Future Milestone & Goals PR: Needs Manager Approval A pull request that needs review from a manager. PR: Needs Team Approval A pull request that needs review from a team member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants