PR from patch-prchecks to main for commit f4111f9#129
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes ingress configurations across AKS and EKS by updating hostnames and prefixing service paths with /v1. It also synchronizes liveness and readiness probes with these new paths and adjusts ALB group ordering for EKS. Feedback identifies inconsistencies between container readiness probes and ingress health checks for the collector service, and points out a recurring typo (heathz instead of healthz) in the firehog service's health probe paths.
| readinessProbe: | ||
| httpGet: | ||
| path: / | ||
| path: /v1/otel-http |
There was a problem hiding this comment.
The readiness probe path is being changed to /v1/otel-http on port 13133. This is inconsistent with the ingress health probe path /v1/otel-http/healthz defined on line 79. If the application serves health status at /v1/otel-http/healthz, this probe should likely match to ensure consistency between container and ingress health checks.
| readinessProbe: | ||
| httpGet: | ||
| path: / | ||
| path: /v1/otel-http |
There was a problem hiding this comment.
The readiness probe path is being changed to /v1/otel-http on port 13133. This is inconsistent with the ingress health check path /v1/otel-http/healthz defined on line 76.
3 participants
This PR is auto-generated by DevOps PR Approval Pipeline