fix: use api_key and provider_name in secret create request

[ankumar]

No description provided.

[gemini-code-assist]

Hello @ankumar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request modifies the create_secret and acreate_secret methods in the SecretService class to use secret.api_key and secret.provider_name instead of secret.name when constructing the request. This change ensures that the API key and provider name are correctly used when creating secrets.

Highlights

• Secret Creation: The create_secret and acreate_secret methods now use secret.api_key and secret.provider_name in the request, instead of secret.name.
• Request Parameters: The Request object is now instantiated with secret.api_key and secret.provider_name as parameters.

Changelog

• javelin_sdk/services/secret_service.py
  • Modified create_secret to use secret.api_key and secret.provider_name in the request.
  • Modified acreate_secret to use secret.api_key and secret.provider_name in the request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

With API key's might,
Secrets take flight,
Provider's name clear,
No room for fear,
Security shines bright.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The code changes involve modifying the create_secret and acreate_secret methods in the SecretService class to include api_key and provider_name in the request. This change enhances the secret creation process by incorporating additional parameters.

Summary of Findings

• Inclusion of api_key and provider_name in secret creation request: The create_secret and acreate_secret methods now include api_key and provider_name in the request, which is a positive step towards providing more context during secret creation. Ensure that these parameters are properly validated and handled on the server-side to prevent any potential issues.

Merge Readiness

The code changes seem straightforward and address the issue of including api_key and provider_name in the secret creation request. However, it's crucial to ensure that the server-side implementation is compatible with these changes and that proper validation is in place. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.