claude code#354
Merged
Merged
Conversation
Owner
himkt
commented
May 22, 2026
himkt
commented
- feat: add claude configs again
- feat: add make recipe to deploy non-Nix managed files
- feat: add option to deploy only non-Nix managed files
Contributor
There was a problem hiding this comment.
Pull request overview
Reintroduces Claude Code configuration into the dotfiles repo and extends the existing simple-deploy workflow so non–Nix-managed files can be deployed separately (useful when only a subset of config should be symlinked outside Nix).
Changes:
- Added a
simple-deploy-nix-unsupported-onlyMake target and a--nix-unsupported-onlyoption inbin/simple-deploy.py. - Added Claude Code settings, hooks, helper scripts, rules, and several skills (GitHub CLI, English review, bilingual explain, NixOS boot troubleshooting, LSP-based symbol tracing).
- Introduced a Bash command validator hook (
validate_bash.py) and a statusline script (status.py) for Claude Code.
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds a new deploy target for only “nix-unsupported” files. |
| bin/simple-deploy.py | Adds --nix-unsupported-only and metadata in DEPLOY_MAP to filter deploy scope. |
| home/modules/claude/files/settings.json | Adds Claude Code settings: permissions, hooks, status line, plugins, model, etc. |
| home/modules/claude/files/bin/validate_bash.py | Adds a shell-command parser/validator used by the PreToolUse hook. |
| home/modules/claude/files/bin/status.py | Adds a status line renderer for model/cwd/cost/context window usage. |
| home/modules/claude/files/bin/english_review.py | Adds a Stop-hook that samples sessions and stores English reviews in SQLite. |
| home/modules/claude/files/rules/tool-discovery.md | Adds guidance to prefer skills/MCP tools when available. |
| home/modules/claude/files/rules/removal.md | Adds guidance for full repo cleanup when removing features/options. |
| home/modules/claude/files/rules/git-workflow.md | Adds git workflow rules (commit message format, no git -C, etc.). |
| home/modules/claude/files/rules/bash-command.md | Adds rules for Bash tool-call safety/pattern matching. |
| home/modules/claude/files/skills/pathfinder-explain/SKILL.md | Adds an LSP-based symbol tracing/explanation skill. |
| home/modules/claude/files/skills/nixos-boot-troubleshoot/SKILL.md | Adds a step-by-step NixOS boot failure troubleshooting skill. |
| home/modules/claude/files/skills/github-cli/SKILL.md | Adds a skill for fetching PR/issue details via gh with focused --jq. |
| home/modules/claude/files/skills/english-review/SKILL.md | Adds the manual English review skill and references the canonical format spec. |
| home/modules/claude/files/skills/english-review/format.md | Defines the canonical output format consumed by the skill + stop hook. |
| home/modules/claude/files/skills/bilingual-explain/SKILL.md | Adds a bilingual response formatting skill (plain English + Japanese). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+46
| simple-deploy-nix-unsupported-only: | ||
| python3 bin/simple-deploy.py --nix-unsupported-only --dry-run | ||
| python3 bin/simple-deploy.py --nix-unsupported-only |
| Rules to ensure Bash commands match `permissions.allow` patterns in settings.json. | ||
| Using shell operators breaks pattern matching and triggers user approval prompts that block work. | ||
|
|
||
| - NEVER use `&&` or `;` to chain commands. Each command must be a separate Bash tool call. Pipes (`|`) are allowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.