Decouple FilterTreeCallbacks from TaskResourceTrackingService#1
Merged
himshikhagupta merged 1 commit intoMay 12, 2026
Conversation
Introduce DelegationThreadTracker interface in the SPI layer so that FilterTreeCallbacks no longer depends on TaskResourceTrackingService directly. The tracker is created as a closure in AnalyticsSearchService where both the service and taskId are naturally available, keeping the FFM callback layer free of core OpenSearch dependencies. Also fixes premature tracker cleanup in the streaming path by tying the tracker lifecycle to FragmentResources.close() instead of a finally block that fires before the stream is consumed. Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
himshikhagupta
merged commit 8d2a60c
into
himshikhagupta:analytics-delegation-task-tracking
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce DelegationThreadTracker interface in the SPI layer so that FilterTreeCallbacks no longer depends on TaskResourceTrackingService directly. The tracker is created as a closure in AnalyticsSearchService where both the service and taskId are naturally available, keeping the FFM callback layer free of core OpenSearch dependencies.
Also fixes premature tracker cleanup in the streaming path by tying the tracker lifecycle to FragmentResources.close() instead of a finally block that fires before the stream is consumed.
Description
[Describe what this change achieves]
Related Issues
Resolves opensearch-project#21610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.