Skip to content

Merge unstable: Fix duplicate modules, add shell env tests#56

Merged
hinriksnaer merged 61 commits into
mainfrom
unstable
Mar 19, 2026
Merged

Merge unstable: Fix duplicate modules, add shell env tests#56
hinriksnaer merged 61 commits into
mainfrom
unstable

Conversation

@hinriksnaer

@hinriksnaer hinriksnaer commented Mar 19, 2026

Copy link
Copy Markdown
Owner

Summary

Merges accumulated changes from unstable to main, including critical bug fix for duplicate module entries and comprehensive test coverage.

Key Changes

1. 🐛 Fix: Duplicate Module Entries (Critical)

Commit: 4253e6e

Fixes bug where deploying external modules with parameters created duplicate entries:

Before:

modules:
  enabled:
    - fedpunk-claude-gauth-example                    # ❌ Duplicate
    - module: https://github.com/.../module.git       # ✅ Correct
      params:
        gcloud_auth: yes

After:

modules:
  enabled:
    - module: https://github.com/.../module.git
      params:
        gcloud_auth: yes

Root cause: deployer.fish normalized URL to name before storing, then param-save-to-config searched for URL and didn't find it, creating duplicate.

Fix: Store original URL instead of normalized name.

2. 🧪 Test: Login vs Non-Login Shell Env Vars

Commit: ddbf2ba

Added regression test reproducing the issue where env vars only available in login shells.

Reproduces user issue:

  • User deployed module
  • Had to run bash again to see CLAUDE_CODE_USE_VERTEX env var
  • Root cause: /etc/profile.d/ only sourced for login shells

Test shows:

❌ BUG REPRODUCED: FEDPUNK_TEST_API not set in non-login shell
    /etc/profile.d/ is NOT sourced for non-login shells

Documents that /etc/profile.d/ approach has limitations for non-login shells.

3. 🧪 Test: Regression Test for Duplicate Bug

Commit: 9707521

Added comprehensive test for the duplicate module bug. Now passes after fix.

Other Changes

  • 881d407 feat: auto-load module env vars in all shells (already merged via PR Auto-load module environment variables in all shells #54)
  • 597c21b test: verify shells actually load environment variables
  • 790b252 fix: remove DEBUG output from module deployment
  • 33ae391 docs: add CHANGELOG.md
  • 6ef75a0 chore: remove MIGRATION.md
  • Plus 14 more commits with test improvements and documentation updates

Testing

# Test duplicate fix
bash test/ci/test-external-module-params-no-duplicate.sh

# Test shell env behavior
bash test/ci/test-env-login-vs-nonlogin-shells.sh

User Impact

✅ Immediate fix for duplicate module entries bug reported in container
✅ Better test coverage for shell environment behavior
✅ Documented limitations of current env var loading approach

Commits Included

Total: ~22 commits from unstable not yet on main

ddbf2ba test: add regression test for login vs non-login shell env vars
4253e6e fix: prevent duplicate module entries when deploying external modules with params
9707521 test: add regression test for external module duplicate entry bug
881d407 feat: auto-load module env vars in all shells via /etc/profile.d
... (18 more)

🤖 Generated with Claude Code

hinriksnaer and others added 30 commits January 2, 2026 08:15
@hinriksnaer @claude
feat: simplify external module storage and add module management comm…
fb2fc6a 
…ands (#47)

* feat(modules): store external modules in ~/.config/fedpunk/modules/

- Change external module storage from cache to user config directory
- Makes modules easily editable without cache invalidation issues
- Add priority-based resolution: profile -> external -> system
- Update documentation to reflect new storage location

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(module): add installed, available, and update commands

- `fedpunk module installed` - Lists deployed modules by type (native/external/profile)
- `fedpunk module available` - Lists modules available to install
- `fedpunk module update <name|all>` - Pulls git updates and redeploys if changed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add install-from-source.sh for local RPM builds

Clean script for building and installing Fedpunk from a git checkout:
- Validates git state and warns about uncommitted changes
- Checks for build dependencies
- Creates proper source tarball from HEAD
- Builds RPM with patched spec file
- Installs with dnf

Usage:
  ./install-from-source.sh           # Build and install
  ./install-from-source.sh --build   # Build only
  ./install-from-source.sh --clean   # Clean artifacts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(install): clean old RPMs and use reinstall for updates

- Remove old fedpunk RPMs before building to avoid stale files
- Find most recently built RPM by modification time
- Use dnf reinstall to force update when version matches

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(module): fix installed command display issues

- Use separate arrays for module names and git status to avoid \t escaping issues
- Deduplicate modules by name (git URL and name can resolve to same module)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(module): show profile modules in installed command

The installed command now shows all deployed modules:
- Modules from fedpunk.yaml (explicitly deployed)
- Modules from active profile's mode.yaml

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* removed external module

* fix(spec): dynamically install all modules instead of hardcoding names

Changed from hardcoded module list to dynamic discovery:
- Installs all modules found in modules/ directory
- No need to update spec when modules are added/removed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(deployer): normalize git URLs to module names in config

When deploying a git URL, store only the module name in config:
- git@gitlab.com:org/thinkpad-fans.git -> thinkpad-fans

This prevents duplicate entries when deploying the same module
by URL and by name, and makes `fedpunk module update` work with
simple names.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(sources): add multi-module source repository support

Add sources concept for managing collections of external modules:
- Create sources.fish library for clone/update/discover operations
- Add fedpunk source CLI (add, list, sync, modules, remove)
- Update module resolver with priority: profile → sources → external → native
- Sync sources automatically before deployment
- Update module installed/available to show source modules

Sources are multi-module git repos stored in ~/.config/fedpunk/sources/
Direct git URLs are stored in ~/.config/fedpunk/modules/

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(sources): add registry format support for source repos

Sources can now be registry repos with modules.yaml that map
module names to their git URLs. This allows a single source
to reference modules in separate git repositories.

Registry format:
```yaml
modules:
  module-name:
    repo: git@gitlab.com:org/module.git
    description: Module description
```

When deploying from a registry, modules are cloned to
~/.config/fedpunk/modules/ like direct git URLs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(cli): move source commands under fedpunk module source

Consolidate source management as a subcommand of module:
- fedpunk module source add <url>
- fedpunk module source list
- fedpunk module source sync
- fedpunk module source modules
- fedpunk module source remove <url>

This makes the CLI hierarchy more intuitive since sources
are module repositories.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(cli): rename source to sources to avoid Fish builtin conflict

The 'source' function name conflicts with Fish's builtin source
command used to load files. Renamed to 'sources' (plural).

Commands are now:
- fedpunk module sources add <url>
- fedpunk module sources list
- fedpunk module sources sync
- fedpunk module sources modules
- fedpunk module sources remove <url>

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(cli): show help when running fedpunk module sources without args

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(cli): support nested command directories for subcommands

The dispatcher now supports three-level commands via nested directories.
For example, cli/module/sources/ creates `fedpunk module sources <cmd>`.

Moved sources subcommands to cli/module/sources/sources.fish:
- fedpunk module sources add
- fedpunk module sources list
- fedpunk module sources sync
- fedpunk module sources modules
- fedpunk module sources remove

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(cli): include subdirectories in discovered subcommands

Updates _discover_functions to list subdirectories as nested command
groups. This allows nested command structures like cli/module/sources/
to appear in the subcommand help output.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(cli): show descriptions for nested command subdirectories

Updates _get_description to check nested subdirectories for group
function descriptions. For example, sources in cli/module/sources/
now shows its description "Manage module sources" in parent help.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(cli): move installed/available under 'module list' subgroup

Creates nested command structure:
  fedpunk module list installed
  fedpunk module list available

This provides cleaner CLI organization and maintains backwards
compatibility with the 'module list' concept from the test.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(module): require nodejs module for npm packages like cargo
0248488 
Update npm package handling to match cargo pattern:
- Check PATH for npm
- Check fnm and nvm fallback locations
- Error if not found, requiring nodejs module as dependency

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat(rpm): add nodejs as required dependency
eb211c2 
npm is needed for module package installation and comes bundled
with the nodejs package.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(module): fail properly when cargo not found
46b26ba 
- Check cargo packages upfront instead of per-package
- Return 1 instead of continue to fail deployment
- Check /root/.cargo/bin as fallback for root users

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat(rpm): add rust and cargo as required dependencies
7438473 
Needed for modules that install packages via cargo (like yazi).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat(ssh): check stable socket before starting new agent
31c5672 
Checks for ~/.ssh/agent.sock (stable symlink from systemd ssh-agent)
before spawning a new agent. This enables reliable SSH agent forwarding
to containers that mount the stable socket path.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(ssh): use correct exit codes for ssh-add agent detection
3b03d1b 
ssh-add -l returns:
- 0: keys listed (connected)
- 1: no identities (connected but empty)
- 2: cannot connect to agent

Previously checked for exit 0, which failed when agent was running
but had no keys loaded. Now correctly checks for exit != 2.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat(ssh): add fish config for stable SSH agent socket
2491c98 
Sets SSH_AUTH_SOCK to ~/.ssh/agent.sock on shell startup if the stable
socket exists. This ensures containers can reliably mount the socket
and SSH agent forwarding works consistently.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs: update for release - remove ssh-clusters, add source commands
547ee7e 
- Remove ssh-clusters references (module was deleted)
- Update module count from 3 to 2 built-in modules
- Add module sources management commands to README
- Document SSH agent stable socket feature
- Update CHANGELOG with new features for this release

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(ssh): create stable socket symlink when starting new agent
8648f1b 
When fedpunk ssh load starts a new agent, create a symlink at
~/.ssh/agent.sock pointing to the actual socket. This ensures
all shells can find the agent via the stable socket path.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(ssh): validate stable socket is responsive before using it
96f4a4f 
The fish config now checks if the stable socket actually works
(agent responds) before setting SSH_AUTH_SOCK, instead of just
checking if the socket file exists.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(spec): prevent .config directory from being owned by root
633b9ba 
The %post script was creating ~/.config/fedpunk with mkdir -p, which
also created the parent .config directory as root. The chown only fixed
the fedpunk subdirectory, leaving .config owned by root.

Now tracks if .config was created and fixes its ownership too.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer
Merge main into unstable: sync upstream changes
6072c2d
@hinriksnaer @claude
feat(profile): preserve git URLs in fedpunk.yaml for declarative conf…
c7a0210 
…ig (#49)

* feat(profile): preserve git URLs in fedpunk.yaml for declarative config

Enable users to declaratively reference git profiles in fedpunk.yaml
by URL, similar to how sources work. The system automatically clones
and updates profiles from git URLs.

Changes:
- Remove line that overwrote profile_to_save with extracted repo name
- Add logic to save basename only for path-based profiles
- Git URLs are now preserved in config instead of being extracted to name
- Add comprehensive test script for git profile URL functionality

Example usage:
```yaml
# Git URL (auto-clones/updates on apply)
profile: git@github.com:user/hyprpunk.git
mode: laptop

# Name (resolves from profile directories)
profile: default
mode: desktop
```

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(module): add declarative environment variable support

Modules can now declare environment variables in module.yaml under an
`environment:` section. Users can also declare global environment
variables in fedpunk.yaml.

Features:
- New env-injector.fish generates ~/.config/fish/conf.d/fedpunk-module-env.fish
- Supports $FEDPUNK_PARAM_* interpolation for dynamic values
- User-defined env vars in fedpunk.yaml override module defaults
- Env config is sourced immediately after deployment

Example module.yaml:
  environment:
    CLAUDE_CODE_USE_VERTEX: "1"
    CLOUD_ML_REGION: "$FEDPUNK_PARAM_CLAUDE_REGION"

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(config): use clean environment for yq to avoid shell pollution (#50)
f347391 
Fedora container images have kiwi_* environment variables that echo
to stdout during shell initialization, polluting yq output.

Added _yq_safe wrapper that runs yq with 'env -i' to avoid picking
up garbage from the shell environment.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(yq): apply clean environment wrapper across all yq calls
8fc11b5 
The previous fix in config.fish only addressed yq calls in that file.
This comprehensive fix:

- Creates shared lib/fish/yq-utils.fish with _yq_safe and _yq_safe_eval
- Updates all files that use yq to source the shared utilities
- Replaces all yq read operations with _yq_safe/_yq_safe_eval
- Prevents kiwi_* environment variable pollution in Fedora containers

Files updated:
- config.fish: Sources shared yq-utils.fish
- deployer.fish: Uses _yq_safe for module list
- env-injector.fish: Uses _yq_safe for environment reading
- module-ref-parser.fish: Uses _yq_safe_eval for parsing
- param-injector.fish: Uses _yq_safe_eval for parameter extraction
- param-prompter.fish: Uses _yq_safe_eval for config reading
- sources.fish: Uses _yq_safe for registry operations
- yaml-parser.fish: Uses _yq_safe/_yq_safe_eval for parsing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer
fix(env): write environment configs to system-wide locations
d3ad440 
Generate /etc/fish/conf.d/fedpunk-env.fish and /etc/profile.d/fedpunk-env.sh
@hinriksnaer @claude
fix(env): write environment configs to user-level locations
f29f6af 
Previously env-injector wrote to /etc/fish/conf.d/ and /etc/profile.d/
which required root access and failed silently without sudo.

Now writes to user-level config:
- Fish: ~/.config/fish/conf.d/fedpunk-module-env.fish (auto-sourced)
- Bash: ~/.config/fedpunk/profile.d/fedpunk-env.sh (source from .bashrc)

This matches how param-injector works and fixes the file path expected
by fedpunk-module.fish line 464.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(deploy): generate env config after module deployment
fd220cd 
Previously, env-generate-fish-config was called BEFORE modules were
deployed, causing module environment variables to not be included
if the modules weren't yet in place (e.g., first-time deployment).

Now env and param config generation happens AFTER all modules are
deployed, ensuring all module.yaml files are available for parsing.

This fixes the issue where environment variables from user modules
(like CLAUDE_CODE_USE_VERTEX) weren't being generated during
fedpunk apply.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(config): prevent duplicate modules in fedpunk.yaml
f092c99 
Use fedpunk-config-list-enabled-modules for the duplicate check,
which properly extracts module names from both simple string and
object formats (module: name with params).

Previously the check used raw YAML which didn't match object entries.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(module-resolver): source paths.fish for FEDPUNK_USER/FEDPUNK_SYSTEM
17eaccc 
The module resolver uses FEDPUNK_USER to find profile modules and
FEDPUNK_SYSTEM to find system modules, but these environment
variables weren't guaranteed to be set when the library was sourced
directly (e.g., during env-generate-fish-config).

This caused profile modules like 'claude' to not be found during
environment variable generation, even though they exist in the
profile's modules directory.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(config): prevent duplicate modules from profile's mode.yaml
9540e7c 
Extend duplicate detection in fedpunk-config-add-module to also check
the active profile's mode.yaml modules list. Previously, running
`fedpunk module deploy <name>` would add a module to modules.enabled
even if it was already part of the deployed profile.

Changes:
- Add fedpunk-config-list-profile-modules helper function
- Check profile modules before adding to modules.enabled
- Add null check and -- flag to contains for robustness

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
Merge branch 'main' into unstable
f2b116a 
Resolve conflict in lib/fish/config.fish by keeping the improved
duplicate detection logic that also checks profile's mode.yaml.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): rewrite intro to emphasize end-to-end orchestration
ddda02d 
- Rewrote "What is Fedpunk?" to highlight full orchestration capabilities:
  dotfiles, packages, env variables, custom CLI, lifecycle scripts, deps
- Moved Architecture section lower (after Profiles)
- Added module resolution priority
- Removed "What is/is not" sections in favor of clearer feature list
- Fixed profile structure: plugins/ → modules/
- Updated nav links

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): add Configuration section with fedpunk.yaml details
c89cd44 
Document the main config file structure and ~/.config/fedpunk directory
layout before diving into the module system.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): remove incorrect root-level params field
c45ccfb 
Params are stored within each module entry, not at root level.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer
Merge docs/readme-update: README improvements
7af2eaf
@hinriksnaer @claude
fix: remove hardcoded theme symlink from core
add83f5 
Theme CLI is external (provided by profiles like hyprpunk).
The symlink pointed to a local user path that wouldn't work on other systems.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
refactor: reorganize test directory structure
ce9c632 
- test/ci/ - CI test scripts (automated)
- test/unit/ - unit tests
- test/container.sh - interactive container testing
- Remove .devcontainer/ (not useful for this project)
- Remove tests/ (merged into test/unit/)
- Move test-local.sh to test/container.sh
- Update CI workflows and docs for new paths

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat(config): restructure profile config with name, source, and mode
94d6770 
Profile config is now an object with three fields:
- name: profile name for local lookup
- source: git URL for fetching/updates (null for local profiles)
- mode: active mode (moved from top-level)

This enables:
- Reproducible configs (source URL preserved)
- Local profile support (source can be null)
- Cleaner organization (mode belongs to profile)

New functions:
- fedpunk-config-set-profile <name> [source] [mode]
- fedpunk-config-set-profile-mode <mode>
- fedpunk-config-get-profile-name
- fedpunk-config-get-profile-source
- fedpunk-config-get-profile-mode

Also:
- Delete obsolete docs/ directory
- Add dev user to test container
- Update tests for new config structure

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hinriksnaer and others added 29 commits March 13, 2026 17:12
@hinriksnaer @claude
fix(config): fix variable scoping in profile getter functions
a8e768e 
Variables declared with 'set -l' inside if blocks are scoped to that
block and not visible outside. Fixed by declaring variables before the
if block.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(config): never overwrite existing config on fresh install
13745cc 
fedpunk-config-init now checks if config file exists before writing,
preventing accidental loss of user configuration. Also consolidates
param-prompter to use canonical config initialization.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test(env): add test for module environment variable injection
e1a4a9b 
Verifies that environment: section in module.yaml and fedpunk.yaml
correctly generates Fish and Bash config files with proper precedence.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs: document environment variable injection in module.yaml
c2cd18d 
Added documentation for:
- environment: section in module.yaml schema
- environment: section in fedpunk.yaml (user overrides)
- env-injector.fish in core libraries list
- Environment injection step in deployment flow

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): remove ssh module references
183c992 
SSH module is no longer a core built-in module. Fedpunk now ships
with only the fish module as its single built-in module.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs: remove fedpunk-minimal references (doesn't exist)
f91bfad 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): expand profiles section and directory structure
e03a2e4 
- Add profile management commands (list, current, deploy, apply)
- Document mode.yaml structure with examples
- Explain git URL deployment workflow
- Expand directory structure with detailed tree showing profiles,
  sources, modules, and generated configs

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test(params): add test for module parameter injection
e48a0c7 
Verifies that parameters: section in module.yaml and params: in
fedpunk.yaml correctly generate FEDPUNK_PARAM_<MODULE>_<KEY>
environment variables.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs: restore ssh module references
4ba3b07 
SSH module does exist in fedpunk, restoring documentation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): add Module CLI and TUI support sections
e9c5b09 
- Document how modules can provide custom CLI commands via cli/ directory
- Show example CLI file structure with subcommands
- Add TUI section explaining gum-based UI elements
- List available ui-* functions for module developers

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(params): inject default parameter values from module.yaml
7a71528 
Previously, only user-provided params were injected. Now the system:
1. Reads parameters: section from module.yaml for defaults
2. Merges with user-provided params (user takes precedence)
3. Generates env vars for all params including defaults

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs(readme): simplify custom modules, reference template repo
6a52eed 
Replace inline module creation guide with link to
fedpunk-module-template repo which has full documentation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat: add module-template as submodule in examples/
55d3fcc 
- Add fedpunk-module-template as git submodule at examples/module-template
- Update README to reference local examples/ path
- Update spec file to install examples directory in RPM

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
chore: configure module-template submodule to track main branch
73def6e 
Run `git submodule update --remote examples/module-template` to pull latest.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix: update docs for minimal core architecture
d04361c 
- Remove dead neovim submodule from .gitmodules
- Update CLAUDE.md: profiles are external only (not 3 built-in)
- Update CLAUDE.md: themes are external only (hyprpunk provides them)
- Update module-template submodule with architecture fixes

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test: add comprehensive CI tests for advanced features
2868b3f 
Add 5 new test files covering:
- Config preservation (init doesn't overwrite existing config)
- Disabled modules (disabled list prevents deployment)
- External modules (git URL cloning to ~/.config/fedpunk/modules/)
- Sources management (add/list/sync/modules commands)
- Lifecycle hooks (before/after hook execution)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test: add comprehensive test suite with parallel CI
e20f17d 
New tests (all run in <2s each):
- test-dependency-resolution: Linear/diamond deps, cycle detection
- test-module-resolver: System/profile/external/source resolution
- test-module-ref-parser: URL/path detection, param extraction
- test-stow-conflicts: Skip/overwrite modes, state tracking
- test-module-unstow: Symlink removal, state cleanup
- test-profile-deploy: Git URL profiles, mode selection
- test-template-module: Uses examples/module-template submodule
- test-yaml-reproducibility: Config determinism
- test-cli-integration: All CLI commands, error handling

CI workflow runs tests in parallel matrix for fast feedback.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(test): use stow instead of deploy in E2E test
cecaab6 
Avoids sudo/package install step that fails in CI containers.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix(test): fix test-profile-git-urls.sh path and config format
6d77041 
- Fixed FEDPUNK_ROOT path (was going to test/ instead of project root)
- Use deployer-deploy-profile instead of deployer-deploy-from-config for initial deploy
- Added test to CI workflow

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
chore: remove MIGRATION.md
6ef75a0 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
docs: add CHANGELOG.md
33ae391 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix: remove DEBUG output from module deployment
790b252 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test: verify shells actually load environment variables
597c21b 
Enhanced test-module-environment.sh to verify that Bash, Fish, and Zsh
shells actually load environment variables when sourcing generated config
files, not just that the files are generated correctly.

This catches the bug where fedpunk-env.sh is generated but not
automatically sourced by Bash/Zsh (unlike Fish which auto-loads from
conf.d/).

New tests:
- Test 6: Bash shell environment loading
- Test 7: Fish shell environment loading
- Test 8: Zsh shell environment loading (skips if zsh not installed)

Each test spawns a fresh shell, sources the config file, and verifies
all environment variables are correctly set.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
feat: auto-load module env vars in all shells via /etc/profile.d
881d407 
Previously, module environment variables were only auto-loaded in Fish
shells via conf.d. Bash/Zsh/Sh required manual sourcing of the config.

Changes:
- Updated /etc/profile.d/fedpunk.sh to auto-source user module env config
- Module env vars now auto-load in Bash, Zsh, Sh without manual setup
- Added comprehensive test coverage for all shells

Benefits:
- Consistent experience across all shells
- Zero manual configuration required
- Immediate availability in new shells after module deployment

Test: bash test/ci/test-external-module-env-immediate.sh

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test: add regression test for external module duplicate entry bug
9707521 
Adds test coverage for bug where deployer-deploy-module creates
duplicate entries in modules.enabled when deploying external modules
with parameters:
  1. First entry: normalized name string (e.g., "module-name")
  2. Second entry: URL with params object

The bug occurs because:
- deployer-deploy-module adds normalized name to config (line 58)
- param-save-to-config searches for URL and doesn't find it
- Creates new entry with URL and params

Expected behavior: Single entry with URL and params
Current behavior: Two entries (bug reproduced by test)

Test currently FAILS (correctly detects bug).
Will PASS after fix to deployer.fish line 58.

Test: bash test/ci/test-external-module-params-no-duplicate.sh

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
fix: prevent duplicate module entries when deploying external modules…
4253e6e 
… with params

Bug: When deploying external modules with parameters via
fedpunk module deploy <url>, two entries were created:
  1. Normalized name string (e.g., "module-name")
  2. URL with params object (e.g., {module: "url", params: {...}})

Root cause: deployer-deploy-module normalized URL to name before
adding to config, then param-save-to-config searched for URL and
didn't find it, creating a duplicate entry.

Fix: Store original module reference (URL) instead of normalized name.
This allows param-save-to-config to find and update the existing entry.

Before:
  modules:
    enabled:
      - fedpunk-claude-gauth-example
      - module: https://github.com/.../fedpunk-claude-gauth-example.git
        params:
          gcloud_auth: yes

After:
  modules:
    enabled:
      - module: https://github.com/.../fedpunk-claude-gauth-example.git
        params:
          gcloud_auth: yes

Test: bash test/ci/test-external-module-params-no-duplicate.sh

Fixes user-reported issue in container deployment.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hinriksnaer @claude
test: add regression test for login vs non-login shell env vars
ddbf2ba 
Reproduces the issue where environment variables are only available
in login shells, not non-login shells (running 'bash' from bash).

Issue: User had to run 'bash' again to see CLAUDE_CODE_USE_VERTEX
env var after module deployment.

Root cause: /etc/profile.d/fedpunk.sh only sourced for LOGIN shells:
  ✅ New terminal sessions (login shell)
  ✅ SSH connections (login shell)
  ❌ Running 'bash' from bash (non-login shell)
  ❌ Current shell after deployment

Test reproduces the bug:
  ❌ BUG REPRODUCED: FEDPUNK_TEST_API not set in non-login shell
      /etc/profile.d/ is NOT sourced for non-login shells

Solutions needed:
  1. Add to /etc/bash.bashrc for non-login interactive shells
  2. Re-source config in current shell during deployment
  3. Add to /etc/zshrc for zsh

Test: bash test/ci/test-env-login-vs-nonlogin-shells.sh

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hinriksnaer
Merge branch 'main' into unstable - resolve test conflict
b02b2e2 
Conflict in test/ci/test-external-module-params-no-duplicate.sh:
- main had the old test (simulating bug with normalized name)
- unstable has the updated test (testing the fix with URL)

Resolution: Keep unstable version since bug is fixed.
@hinriksnaer @claude
fix: convert relative paths to absolute when storing module references
f0d32a9 
Bug: After fixing duplicate URL entries, relative paths like ./module
were stored as-is, breaking resolution from different directories.

Root cause: Removed ALL normalization, including path expansion.

Fix: Normalize paths while preserving URLs:
  - URLs: Keep as-is (prevents duplicate entries)
  - Paths: Convert to absolute (./module → /full/path/module)
  - Names: Keep as-is (simple module names)

Example:
  Input: ./my-module (from /home/user/project)
  Stored: /home/user/project/my-module
  Resolves correctly from any directory ✅

Test: bash test/ci/test-local-path-modules.sh
Test: bash test/ci/test-external-module-params-no-duplicate.sh

Fixes regression introduced in duplicate entry fix.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hinriksnaer hinriksnaer merged commit 498acfe into main Mar 19, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hinriksnaer