ci: fix environment detection for workflow_dispatch#25
Merged
Conversation
…b.ref instead of github.event_name to determine deploy environment. This correctly maps workflow_dispatch on main to prod (previously resulted in empty environment). Matches the pattern already used in pylibs_flow.yml. Session: claude -r 1b942263-65e5-41f0-b445-cc9a1b3f3cd8
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated GitHub Actions workflow deployment logic to trigger production deployment when pushing to the main branch instead of on any push event, and added a default fallback environment variable. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lambda_flow.ymlenvironment logic from checkinggithub.event_name == pushto checkinggithub.ref == refs/heads/mainworkflow_dispatchon main to prod (previously resulted in empty environment, falling through todefault)pylibs_flow.ymldefaultfallback for non-main branchesContext: Companion to hipponot/microservices PR that removes auto-deploy on push to main. This fix ensures manual workflow_dispatch correctly targets prod.
Test plan
Summary by CodeRabbit