Skip to content

ci: add fail-fast: false to lambda matrix strategy#26

Merged
SethPaul merged 3 commits into
mainfrom
fix/lambda-matrix-fail-fast
Mar 13, 2026
Merged

ci: add fail-fast: false to lambda matrix strategy#26
SethPaul merged 3 commits into
mainfrom
fix/lambda-matrix-fail-fast

Conversation

@SethPaul
Copy link
Copy Markdown
Collaborator

@SethPaul SethPaul commented Mar 13, 2026

Summary

  • Adds fail-fast: false to the lambda_flow matrix strategy in lambda_trigger_common.yml
  • Prevents unrelated service deploy failures (e.g. CloudFormation ROLLBACK_FAILED) from canceling sibling test/deploy jobs

Test plan

  • Verify CI runs all matrix jobs independently even when one fails

Summary by CodeRabbit

  • Chores
    • CI updated to prevent early termination of parallel validation jobs so all checks run to completion, improving build reliability and feedback consistency.
    • Deployment workflows: upgraded artifact download action and updated SAM CLI installation method to keep tooling current and stable.

Prevents unrelated service deploy failures from canceling sibling
test/deploy jobs in the matrix.

Session: claude -r e3673d72-1aa9-43c4-bb0f-a12b68a28822
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e5541cc-5c18-44eb-947f-a87f17f1f684

📥 Commits

Reviewing files that changed from the base of the PR and between 77175f4 and 8996d29.

📒 Files selected for processing (1)
  • .github/workflows/lambda_deploy.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/lambda_deploy.yml

Walkthrough

Updated GitHub Actions workflows: added fail-fast: false to the lambda_flow job strategy in .github/workflows/lambda_trigger_common.yml; in .github/workflows/lambda_deploy.yml bumped dawidd6/action-download-artifact from v6 to v7 and replaced aws-actions/setup-sam@v2 with an uv tool install aws-sam-cli step.

Changes

Cohort / File(s) Summary
Workflow: matrix behavior
./.github/workflows/lambda_trigger_common.yml
Added fail-fast: false to the lambda_flow job strategy so matrix runs continue even if some jobs fail.
Workflow: deploy actions
./.github/workflows/lambda_deploy.yml
Upgraded dawidd6/action-download-artifact from v6 to v7; replaced aws-actions/setup-sam@v2 step with an uv tool install aws-sam-cli Install SAM CLI step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding fail-fast: false to the lambda matrix strategy, which is the primary modification in lambda_trigger_common.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/lambda-matrix-fail-fast
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Session: claude -r 8814336c-e6bc-4626-9edf-a4f3189729c1
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/lambda_deploy.yml (1)

88-95: ⚠️ Potential issue | 🔴 Critical

Workflow is incompatible with v7 of the action—all referenced inputs are missing.

The workflow at lines 88-95 uses dawidd6/action-download-artifact@v7, but verification shows that v7 does not define the inputs currently being passed: name, path, workflow_conclusion, and search_artifacts are all missing from v7's interface. The workflow will fail with undefined input errors.

Either downgrade to a v7-compatible version that supports these inputs, or identify the correct input names for v7 and update them accordingly.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/lambda_deploy.yml around lines 88 - 95, The workflow step
using dawidd6/action-download-artifact@v7 is passing inputs that v7 no longer
exposes (name, path, workflow_conclusion, search_artifacts); fix by either
pinning a version that supports those inputs (e.g., switch to the previous
compatible tag) or update the step to use v7's correct input names and semantics
per the v7 action README (locate the step with id get_packaged and replace the
inputs accordingly or change the action version to one that supports
name/path/workflow_conclusion/search_artifacts).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/lambda_deploy.yml:
- Around line 88-95: The workflow step using dawidd6/action-download-artifact@v7
is passing inputs that v7 no longer exposes (name, path, workflow_conclusion,
search_artifacts); fix by either pinning a version that supports those inputs
(e.g., switch to the previous compatible tag) or update the step to use v7's
correct input names and semantics per the v7 action README (locate the step with
id get_packaged and replace the inputs accordingly or change the action version
to one that supports name/path/workflow_conclusion/search_artifacts).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27b1ee58-9f41-4dae-90f3-76581c48c01c

📥 Commits

Reviewing files that changed from the base of the PR and between 165a688 and 77175f4.

📒 Files selected for processing (1)
  • .github/workflows/lambda_deploy.yml

setup-sam@v2 is stuck on Node.js 20 with no update from AWS.
uv tool install is faster and has no Node.js dependency.

Session: claude -r 8814336c-e6bc-4626-9edf-a4f3189729c1
@SethPaul SethPaul merged commit 9a10fb7 into main Mar 13, 2026
2 checks passed
@SethPaul SethPaul deleted the fix/lambda-matrix-fail-fast branch March 13, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant