Convert IPaddress to string using a char array instead of a String#14
Merged
hirotakaster merged 3 commits intohirotakaster:masterfrom Mar 19, 2020
Merged
Convert IPaddress to string using a char array instead of a String#14hirotakaster merged 3 commits intohirotakaster:masterfrom
hirotakaster merged 3 commits intohirotakaster:masterfrom
Conversation
Author
|
Note that this was also proposed in #5 :) |
Owner
|
@alexmrqt thank you for your pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any IPv4 address can be represented as a string between 16 (15 + '\0') and 8 (7 + '\0') characters :
Memory fragmentation due to String allocation can cause crash or undefined behaviors in microcontrollers. This is especially true for very constrained device like the atmega328p in the Arduino Uno.
This PR address this issue by changing the type of
ipaddresstochar[16], allowing for static memory allocation.int -> string conversion is then handled by
sprintf().