Skip to content

fix(mirrors): preserve help sidebar position - #12

Merged
ZreXoc merged 1 commit into
mainfrom
codex/help-sidebar-navigation
Sep 17, 2026
Merged

ZreXoc merged 1 commit into
mainfrom
codex/help-sidebar-navigation

Conversation

@shirok1

@shirok1 shirok1 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • persist the same help sidebar island across help-page navigation
  • save sidebar scroll before the Astro swap and restore it after navigation settles
  • remove automatic recentering of the active help entry

Verification

  • bun run check in apps/mirrors — 0 errors, warnings, or hints
  • manual click test: PyPI remains at scrollTop = 2000 after navigation

Demonstration

Before — clicking recenters the sidebar

before-scroll-persistence.mp4

After — clicking preserves the sidebar position

after-scroll-persistence.mp4

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying frontend-landing with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4588ede
Status: ✅  Deploy successful!
Preview URL: https://ae6972c3.frontend-landing-3nl.pages.dev
Branch Preview URL: https://codex-help-sidebar-navigatio.frontend-landing-3nl.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying frontend-mirrors with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4588ede
Status: ✅  Deploy successful!
Preview URL: https://df47768c.frontend-mirrors.pages.dev
Branch Preview URL: https://codex-help-sidebar-navigatio.frontend-mirrors.pages.dev

View logs

@ZreXoc
ZreXoc merged commit 43144cd into main Sep 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants