Merged
Conversation
LPTK
requested changes
Mar 13, 2026
| //│ ═══[RUNTIME ERROR] RangeError: Maximum call stack size exceeded | ||
|
|
||
|
|
||
| // * For some reason, this works locally with values 100 and 100, |
Contributor
There was a problem hiding this comment.
It would be nice to still leave a comment explaining what was happening here before this change (the cause of the flakiness).
hkmc2/shared/src/main/scala/hkmc2/codegen/HandlerLowering.scala
Outdated
Show resolved
Hide resolved
Closed
LPTK
approved these changes
Mar 14, 2026
Comment on lines
+276
to
+277
| // See https://github.com/hkust-taco/mlscript/pull/410 | ||
| // This test was failing non-deterministically due to handler state not being properly reset. |
Contributor
There was a problem hiding this comment.
Come on. That's a very poor effort at documentation. That PR does nor povide any explanation.
Suggested change
| // See https://github.com/hkust-taco/mlscript/pull/410 | |
| // This test was failing non-deterministically due to handler state not being properly reset. | |
| // This test was failing non-deterministically due to handler state not being properly reset. | |
| // The flakiness was due to the stack overflow in the previous block not always interrupting the code in the same place, | |
| // sometimes leaving the effect handlers runtime in an inconsistent state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue of the non deterministic test failure.