wasm: Refactor fully to use symbolic indices#417
Conversation
- User-defined types will use the type name as its symbolic index ID - Synthetic types will use a generated name based on its context as its symbolic index ID
LPTK
left a comment
There was a problem hiding this comment.
Neat, thanks!
But is there any plan to move away from the deprecated stuff? Did you leave it there to help the FYP students? Also, does it really need to be deprecated?
The implementation has fully moved away from the deprecated stuff. The only locations that still retains numeric indices is
Yes. I have tried to make all changes API-compatible to ensure that their changes can be applied on top of this with minimal changes.
I am not sure. It just seems like a good idea to force people to move away from using numeric indices before it is fully removed or made |
Refactor all usages of numeric indices to symbolic indices, so that all top-level module constructs are named.
No functionality changes, except all functions are exposed as element segments. This allows any function to be called using
call_reffor consistency.