Merged
Conversation
tabcat
reviewed
Nov 20, 2023
Member
tabcat
left a comment
tabcat
left a comment
There was a problem hiding this comment.
Looks good 👍 just the one comment and we can get this merged 💯
Also, wondering if it was necessary to bump zzzync with the libp2p bump
Contributor
Author
Yeah, the old zzzync uses the older interfaces which were giving errors. |
Member
|
plan to refactor tests and test utils in the future so everything is less flaky, already started #103 but thinking about refactoring code first and closing that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all the libp2p related packages to make it work with the newer versions of libp2p.
The breaking changes is the libp2p streams interface that has changed - as far as I can tell this only breaks the bootstrap replicator.