Replace deprecated qt_add_translation function#3461
Open
QuentiumYT wants to merge 1 commit intohluk:masterfrom
Open
Replace deprecated qt_add_translation function#3461QuentiumYT wants to merge 1 commit intohluk:masterfrom
QuentiumYT wants to merge 1 commit intohluk:masterfrom
Conversation
Contributor
Author
|
Oh yes Qt5 doesn't support it, would you like me to add a fallback? if("${QT_VERSION_MAJOR}" STREQUAL "5")
qt5_add_translation(copyq_QM ${copyq_TRANSLATIONS})
else()
qt6_add_translations(copyq-common TS_FILES ${${PROJECT_NAME}_translations} QM_FILES_OUTPUT_VARIABLE copyq_QM)
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, the qt_add_translation is deprecated (as per https://doc.qt.io/qt-6/qtlinguist-cmake-qt-add-translation.html)
Also while trying to package your app, I struggled with
set(copyq_DEFINITIONS ${${copyq_qt}Widgets_DEFINITIONS}). It seems to look for extra widgets definitions but launchpad didn't work. Looks fine without it so I'm wondering if it's still needed.Thanks for your reply :)