Skip to content

Phase2 enable artifact registry proxy - #3

Open
hmariset wants to merge 7 commits into
mainfrom
phase2-enable-artifact-registry-proxy
Open

Phase2 enable artifact registry proxy#3
hmariset wants to merge 7 commits into
mainfrom
phase2-enable-artifact-registry-proxy

Conversation

@hmariset

Copy link
Copy Markdown
Owner

Disable nginx in squid component and enable artifact-registry-proxy component.
ArgoCD adopts existing nginx resources in-place due to Prune=false annotations
from Phase 1, ensuring zero-downtime migration with identical selector labels.

Co-Authored-By: Claude Sonnet 4.5

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Kustomize Render Diff

Comparing ed9c41b7f45a8f641a

Component Environment Changes
components/artifact-registry-proxy/development development +20 -121
components/has/development development +1 -1
components/squid/development development +0 -353
components/artifact-registry-proxy/staging production +49 -150
components/artifact-registry-proxy/staging staging +49 -150
components/squid/staging staging +0 -360

Total: 6 components, +119 -1135 lines

📋 Full diff available in the workflow summary and as a downloadable artifact.

@codecov-commenter

codecov-commenter commented Jul 15, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.11%. Comparing base (ed9c41b) to head (49b5284).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   57.11%   57.11%           
=======================================
  Files          23       23           
  Lines        1455     1455           
=======================================
  Hits          831      831           
  Misses        548      548           
  Partials       76       76           
Flag Coverage Δ
go 57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Disable nginx in squid component and enable artifact-registry-proxy component.
ArgoCD adopts existing nginx resources in-place due to Prune=false annotations
from Phase 1, ensuring zero-downtime migration with identical selector labels.

Changes:
- Disable nginx.enabled in squid (dev/staging)
- Add artifact-registry-proxy ArgoCD ApplicationSet
- Remove Prune=false patches from squid (no longer needed)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@hmariset
hmariset force-pushed the phase2-enable-artifact-registry-proxy branch from 78f7c4c to 5e2dd53 Compare July 16, 2026 14:51
No functional change, just reordering patches to reduce diff noise.
@hmariset
hmariset force-pushed the phase2-enable-artifact-registry-proxy branch from 5e2dd53 to 027521a Compare July 16, 2026 14:53
hmariset added 4 commits July 16, 2026 12:10
…roxy

Add Prune=false annotations to nginx resources in squid component and remove
releaseName from artifact-registry-proxy component. This enables in-place adoption
of existing nginx resources without service interruption or StatefulSet recreation.

Co-Authored-By: Claude Sonnet 4.5
- Updated chart version to 0.1.1779+f29d8f2
- Disabled self-signed certificate infrastructure
- Removed squid-specific config from artifact-registry-proxy
- Removed trusted-ca ConfigMap from artifact-registry-proxy base
Version 0.1.1779+f29d8f2 has missing exporter image. Use the stable
version from main branch that has all required images published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants